git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/2] http.c: prompt for SSL client certificate password

From
Nanako Shiraishi <nanako3@lavabit.com>
Date
Jun 11, 2009, 23:42 UTC
Message-ID
<20090612084209.6117@nanako3.lavabit.com>
In-Reply-To
<ca433830906111600n2d45b5bdg3fb6e7c0a537ec78@mail.gmail.com>
Quoting Mark Lodato <lodatom@gmail.com>:
> Any other thoughts, one way or the other?  Adding proper SSL/PKI
> support would really help git adoption in the corporate world.  I am
> willing to make any changes necessary to get this into git.git.
Somebody mentioned that your patch forces people to type password even when the certificate isn't encrypted. How was this issue addressed?
It would be ideal if you can inspect the certificate and decide if you need to ask for decrypting password before using it (and otherwise you don't ask). If you can't do that, probably you can introduce a config var that says "this certificate is encrypted", and bypass your new code if that config var isn't set.
That way, people who are used to the old behavior don't have to change anything in their set-up.
If people didn't have to type password at all, and after your patch if they are forced to do something else to keep the old set-up working, that isn't nice.
-- 
Nanako Shiraishi
http://ivory.ap.teacup.com/nanako3/
Previous: Mark LodatoNext: Junio C Hamano
Message 7 of 25 in “http.c: prompt for SSL client certificate password”
  1. 1/2 http.c: prompt for SSL client certificate passwordMark Lodato, May 28, 2009
  2. 2/2 http.c: add http.sslCertNoPass optionMark Lodato, May 28, 2009
  3. Mark LodatoJun 5, 2009
  4. Constantine PlotnikovJun 5, 2009
  5. Mark LodatoJun 7, 2009
  6. Mark LodatoJun 11, 2009
  7. Nanako ShiraishiJun 11, 2009
  8. Junio C HamanoJun 11, 2009
  9. Daniel StenbergJun 12, 2009
  10. Constantine PlotnikovJun 12, 2009
  11. Jakub NarebskiJun 12, 2009
  12. Rogan DawesJun 12, 2009
  13. Mark LodatoJun 12, 2009
  14. Mark LodatoJun 12, 2009
  15. Junio C HamanoJun 13, 2009
  16. Mark LodatoJun 13, 2009
  17. Daniel StenbergJun 13, 2009
  18. Junio C HamanoJun 11, 2009
  19. Mark LodatoJun 12, 2009
  20. Junio C HamanoJun 12, 2009
  21. Daniel StenbergJun 12, 2009
  22. Mark LodatoJun 12, 2009
  23. Junio C HamanoJun 13, 2009
  24. Mark LodatoJun 13, 2009
  25. Junio C HamanoJun 13, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.