Re: [bug] git cannot find "git pull"?

From: Todd Zullinger <tmz@pobox.com>
Date: Jun 12, 2009, 03:18 UTC
Message-ID: <20090612031853.GC5076@inocybe.localdomain>
In-Reply-To: <7v7hzidvcj.fsf@alter.siamese.dyndns.org>

Junio C Hamano wrote:

Show 14 quoted lines

> Todd Zullinger <tmz@pobox.com> writes:
>
>> It is notable that Fedora 11 is the first Fedora release that
>> follows the git 1.6.x defaults and installs most git binaries
>> outside of PATH.  I don't think that would cause this, and I
>> haven't had any troubles running these packages for many months,
>> but that's never stopped really obvious bugs in the past...
>
> I do not follow distro packaged versions of git, but it may help to
> double check your spec changes against the output of
>
>     $ git log -p v1.5.6..v1.6.2.2 -- git.spec.in
>
> to see which paths need to be updated.

AFAIK, we're installing things in the correct locations. git-pull is located with the rest of the git commands in /usr/libexec/git-core (which is what 'git --exec-path' shows).

The Fedora 10 packages (unfortunately, IMO) set gitexecdir=%{_bindir}, but that was rectified as soon as the Fedora 11 cycle started and we tried to track each upstream git release closely until things were frozen to make the release. I know there are a good number of fedora developers and packagers who use git, so I would really expect that we'd have seen pitchfork wielding mobs if we broke the packaging badly. ;)

Show 5 quoted lines

> Of course, you might not be using a specfile remotely similar to
> what we have in-tree (I believe it was originally done by Chris
> Wright who is listed as one of the persons who have something to do
> with Fedora packaged versions of git in your maintainers list), so
> this may not be a helpful tip at all, in which case I apologize...

Your help and insight is always welcome Junio. :)

Chris has been busy with other things for a while. I started helping with git package maintenance only in the last 6 months or so. Over time, the spec file we have has drifted a bit from what is in git.git, though not terribly so. I need to spend some time and look at what, if any, changes in the Fedora spec file would be good candidates for submitting to git.git. I have been primarily concerned with making things work cleanly on Fedora and RHEL/CentOS though, so some of the changes may not be as generic as they ought to be if they are to be included in git.git.

-- 
Todd        OpenPGP -> KeyID: 0xBEAF0CE3 | URL: www.pobox.com/~tmz/pgp
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Rowe's Rule: The odds are five to six that the light at the end of the
tunnel is the headlight of an oncoming train.
    -- Paul Dickson