Re: [PATCH v3 1/3] Introduce die_errno() that appends strerror(errno) to die()
- From
Jeff King <peff@peff.net>
- Date
- Jun 8, 2009, 22:07 UTC
- Message-ID
- <20090608220713.GB29942@sigill.intra.peff.net>
- In-Reply-To
- <5f43aa9d0b69e99600a73bddd4c93217608ab661.1244494647.git.trast@student.ethz.ch>
On Mon, Jun 08, 2009 at 11:02:18PM +0200, Thomas Rast wrote:
Show 11 quoted lines
> +void die_errno(const char *fmt, ...)
> +{
> + va_list params;
> + char fmt_with_err[1024];
> +
> + snprintf(fmt_with_err, sizeof(fmt_with_err), "%s: %s", fmt, strerror(errno));
> +
> + va_start(params, fmt);
> + die_routine(fmt_with_err, params);
> + va_end(params);
> +}Aren't you assuming that strerror(errno) has no '%'-signs here, which is what kicked off the whole discussion?
-Peff