Re: [Patch] Prevent cloning over http from spewing

From: Jeff King <peff@peff.net>
Date: Jun 8, 2009, 11:54 UTC
Message-ID: <20090608115431.GC13775@coredump.intra.peff.net>
In-Reply-To: <be6fef0d0906070331y5fd596d1k67893a96a4d872ac@mail.gmail.com>

On Sun, Jun 07, 2009 at 06:31:38PM +0800, Tay Ray Chuan wrote:

Show 6 quoted lines

> >     something like
> >        Fetching %s (got %d packs, %d loose): (%d/%d)
> [...]
> Hmm, just wondering, is this is the intended display for "-q" or "-v"?
> Or should I do isatty(), like builtin-pack-objects.c does for the
> "Writing objects" progress indicator?

I was imagining:

  - without "-q", show progress if isatty(1).

  - with "-q", never show progress

  - with "-v", show the "getting pack" and "walk" output we show now;
    without "-v", don't show it. "-v" has no impact on the progress
    indicator.

-Peff