git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 15/23] http.c: new functions for the http API

From
Jakub Narebski <jnareb@gmail.com>
Date
Jun 6, 2009, 07:21 UTC
Message-ID
<200906060921.30582.jnareb@gmail.com>
In-Reply-To
<be6fef0d0906051808k19a5a4acu29713c5e84fac4d7@mail.gmail.com>
On Sat, 6 Jun 2009, Tay Ray Chuan wrote:
> On Sat, Jun 6, 2009 at 4:50 AM, Jakub Narebski<jnareb@gmail.com> 
wrote:
Show 6 quoted lines
> > Or perhaps it better be
> >  "http.c: Add http_get_strbuf() and http_get_file() to http API"
> 
> I also add http_error(). Listing out 1 or 2 functions in the subject
> is ok, but 3 is a stretch, IMO; I think the reader can know the
> functions added by reading the commit message.

You are right. Somehow I missed mentioning http_error() in the commit message.

> 
> Perhaps you think an enumerated list of the functions added in the
> commit message would be preferable?

I think the way you did in other commit messages in this thread, with enumerated list of added functions (even if in case of this patch they are set, rather than sequence), and later description of each function (or subset of function) is a better way.

-- 
Jakub Narebski
Poland
Previous: Tay Ray Chuan
Message 4 of 4 in “http.c: new functions for the http API”
  1. 15/23 http.c: new functions for the http APITay Ray Chuan, Jun 5, 2009
  2. Jakub NarebskiJun 5, 2009
  3. Tay Ray ChuanJun 6, 2009
  4. Jakub NarebskiJun 6, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.