Re: [TopGit PATCH] pre-commit: check .top* files in the to-be-commited tree

From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Date: Jun 4, 2009, 05:27 UTC
Message-ID: <20090604052716.GA24414@pengutronix.de>
In-Reply-To: <1243975238-4807-1-git-send-email-bert.wesarg@googlemail.com>

Hi Bert,

On Tue, Jun 02, 2009 at 10:40:38PM +0200, Bert Wesarg wrote:

> We currently check fo these files only in the working tree. But we should check
> what would be commited. We use write-tree to be able to utilize ls-tree and
> check the result.

<nitpick> I prefer not speaking about "us" in the commit log. Better use passive voice. </nitpick> So what about:

The pre-commit hook used to check that the working copy has the .top* files. Instead of that assert that the tree that is about to be commited has these files.

> +# I suspect this can't fail, but who knows
> +tree=$(git write-tree) ||
> +	die "Can't write tree"

Actually you don't need to write the tree.  You can use:

	git cat-file -t :0:.topdeps
	-> blob

	git cat-file blob :0:.topdeps | grep .

Up to now I only shortly looked at your patches, but they seem to be OK. I hope I get around to push the changes later today.

Best regards Uwe

-- 
Pengutronix e.K.                              | Uwe Kleine-König            |
Industrial Linux Solutions                    | http://www.pengutronix.de/  |