git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] git-svn: let 'dcommit $rev' work on $rev instead of HEAD

From
EWEric Wong <normalperson@yhbt.net>
Date
Jun 4, 2009, 02:45 UTC
Message-ID
<20090604024527.GA19622@dcvr.yhbt.net>
In-Reply-To
<64a802c5249465dc9e39faa480133f501e5d1b59.1243609198.git.trast@student.ethz.ch>
Thomas Rast <trast@student.ethz.ch> wrote:
Show 18 quoted lines
> 'git svn dcommit' takes an optional revision argument, but the meaning
> of it was rather scary.  It completely ignored the current state of
> the HEAD, only looking at the revisions between SVN and $rev.  If HEAD
> was attached to $branch, the branch lost all commits $rev..$branch in
> the process.
> 
> Considering that 'git svn dcommit HEAD^' has the intuitive meaning
> "dcommit all changes on my branch except the last one", we change the
> meaning of the revision argument.  git-svn temporarily checks out $rev
> for its work, meaning that
> 
> * if a branch is specified, that branch (_not_ the HEAD) is rebased as
>   part of the dcommit,
> 
> * if some other revision is specified, as in the example, all work
>   happens on a detached HEAD and no branch is affected.
> 
> Signed-off-by: Thomas Rast <trast@student.ethz.ch>

Thanks. Took me a while to remember why dcommit was was the way it originally was and I couldn't remember for the life of me.

Acked and pushed out to git://git.bogomips.org/git-svn
-- 
Eric Wong
Previous: Thomas Rast
Message 2 of 2 in “git-svn: let 'dcommit $rev' work on $rev instead of HEAD”
  1. git-svn: let 'dcommit $rev' work on $rev instead of HEADThomas Rast, May 29, 2009
  2. Eric WongJun 4, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.