git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] completion: Add --full-diff to log/gitk options

From
Todd Zullinger <tmz@pobox.com>
Date
Jun 3, 2009, 12:22 UTC
Message-ID
<20090603122230.GZ28808@inocybe.localdomain>
In-Reply-To
<7vzlcrihew.fsf@alter.siamese.dyndns.org>
Signed-off-by: Todd Zullinger <tmz@pobox.com>
---
Junio C Hamano wrote:
Show 12 quoted lines
> Thomas Spura <tomspur@fedoraproject.org> writes:
>
>> If running "git log -p parse-options.*", the last commit is
>> df217ed6430efe444a09fffdafd39720ae3f9864
>> There are the changes this commit makes towards parse-options.*.
>>
>> I was expecting to see the full commit with all changes and not only
>> towards the 2 files - only including the two files.
>>
>> Is my expactation wrong or is this a bug?
>
> Time to run "man git-log" and look for --full-diff, perhaps?

While this patch won't do much to help people find the option, perhaps those who learn about it will appreciate not having to type it. :)

I *think* __git_log_gitk_options is the proper place for it, but it's early in the a.m. and I'm not averse to being proved wrong.

 contrib/completion/git-completion.bash |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
index 0c8bb53..2b291ea 100755
--- a/contrib/completion/git-completion.bash
+++ b/contrib/completion/git-completion.bash
@@ -1117,7 +1117,7 @@ __git_log_common_options="
 "
 # Options that go well for log and gitk (not shortlog)
 __git_log_gitk_options="
-	--dense --sparse --full-history
+	--dense --sparse --full-diff --full-history
 	--simplify-merges --simplify-by-decoration
 	--left-right
 "
-- 
1.6.3.1

-- 
Todd        OpenPGP -> KeyID: 0xBEAF0CE3 | URL: www.pobox.com/~tmz/pgp
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Going to hell when I die would just be redundant.
Previous: Junio C HamanoNext: Thomas Rast
Message 3 of 6 in “wrong expectation from "git log -p"”
  1. Thomas SpuraJun 2, 2009
  2. Junio C HamanoJun 2, 2009
  3. completion: Add --full-diff to log/gitk optionsTodd Zullinger, Jun 3, 2009
  4. Thomas RastJun 3, 2009
  5. completion: Add --full-diff to log optionsTodd Zullinger, Jun 3, 2009
  6. Eric WongJul 5, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.