Re: [PATCH 3/3] Makefile: add commented out 's for Emacs here, too
- From
Markus Heidelberg <markus.heidelberg@web.de>
- Date
- May 30, 2009, 22:01 UTC
- Message-ID
- <200905310001.44532.markus.heidelberg@web.de>
- In-Reply-To
- <7vr5y6z9xp.fsf@alter.siamese.dyndns.org>
Junio C Hamano, 30.05.2009:
Show 14 quoted lines
> Markus Heidelberg <markus.heidelberg@web.de> writes: > > >> +# unconfuse Emacs: ' > >> + > >> +# The above comment is in case there is an odd number of _SQ > >> +# definitions above, since they seem to confuse Emacs. If there is an > >> +# even number of such definitions, it does no harm, since emacs > >> +# doesn't recognize string delimiters inside recognized comments. > > ... > > I think this is way too much comment and would prefer none at all. I > > also would remove the global 4-line comment. > > I personally do not like contaminating our source files with this kind of > magic crufts just to please broken tools [...]
Neither do I like it. That's why I wrote, I wasn't sure whether this should be applied.
In the buildroot project (it consists of Makefiles) there a lots of those workarounds. There was a patch on the list to replace all $(strip $(subst ",,$(FOO))) with $(call strip_dquotes, $(FOO)), but $(call) is not allowed in git for compatibility reasons.
Markus