git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] bisect: use "clear_commit_marks" after checking ancestors

From
Christian Couder <chriscool@tuxfamily.org>
Date
May 28, 2009, 21:24 UTC
Message-ID
<20090528212444.4034.68662.chriscool@tuxfamily.org>
instead of "unparse_commit", as it is enough to just clear flags.
Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
---
 bisect.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
	As the patch series where "unparse_commit" is added and
	used is already in "next". Here is a patch to use
	"clear_commit_marks" instead. The patch that adds
	"unparse_commit" can be reverted from "next" after this
	one.
diff --git a/bisect.c b/bisect.c
index c43c120..18f9fa4 100644
--- a/bisect.c
+++ b/bisect.c
@@ -771,7 +771,7 @@ static int check_ancestors(const char *prefix)
 	/* Clean up objects used, as they will be reused. */
 	for (i = 0; i < pending_copy.nr; i++) {
 		struct object *o = pending_copy.objects[i].item;
-		unparse_commit((struct commit *)o);
+		clear_commit_marks((struct commit *)o, ALL_REV_FLAGS);
 	}
 
 	return res;
-- 
1.6.3.GIT
Message 1 of 1 in “bisect: use "clear_commit_marks" after checking ancestors”
  1. bisect: use "clear_commit_marks" after checking ancestorsChristian Couder, May 28, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.