git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/5] Speeding up "git status" and "git diff --cached"

From
Jeff King <peff@peff.net>
Date
May 25, 2009, 10:59 UTC
Message-ID
<20090525105917.GA27070@coredump.intra.peff.net>
In-Reply-To
<1243106678-6343-1-git-send-email-gitster@pobox.com>
On Sat, May 23, 2009 at 12:24:33PM -0700, Junio C Hamano wrote:
> Here is a refined version of an earlier patch series to use cache-tree
> information to optimize comparison between the index with an existing
> commit.

I just read through the series, and it looks sane to me. My only concern would be that we are forgetting some option that needs to disable the optimization (in the same way that find-copies-harder) does, but I couldn't think of one. And that is, after all, what cooking it in next is for. :)

But I am not terribly familiar with the cache-trees corner of the code, so take my endorsement with a grain of salt.

There is a minor typo in the subject of 2/5.
-Peff
Previous: Junio C Hamano
Message 7 of 7 in “Speeding up "git status" and "git diff --cached"”
  1. 0/5 Speeding up "git status" and "git diff --cached"Junio C Hamano, May 23, 2009
  2. 1/5 write-tree --ignore-cache-treeJunio C Hamano, May 23, 2009
  3. 2/5 cache-tree.c::cache_tree_find(): simplify inernal APIJunio C Hamano, May 23, 2009
  4. 3/5 t4007: modernize the styleJunio C Hamano, May 23, 2009
  5. 4/5 Optimize "diff-index --cached" using cache-treeJunio C Hamano, May 23, 2009
  6. 5/5 Avoid "diff-index --cached" optimization under --find-copies-harderJunio C Hamano, May 23, 2009
  7. Jeff KingMay 25, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.