Re: [PATCH 0/3] http*: refactor fetching code (v2)
- From
Mike Hommey <mh@glandium.org>
- Date
- May 20, 2009, 07:43 UTC
- Message-ID
- <20090520074352.GC21455@glandium.org>
- In-Reply-To
- <20090518163025.58842505.rctay89@gmail.com>
On Mon, May 18, 2009 at 04:30:25PM +0800, Tay Ray Chuan wrote:
Show 18 quoted lines
> This patch series applies on pu.
>
> The major differences between this series and the 11-patch long one
> (dated May 15, 2009) are:
>
> *check 'preq' pointer before using it (for fetching packs) [1]
> *moved free(url) before 'abort' label to stop -Wuninitialized warning
> (for fetching loose objects) [2]
> *use unlink_or_warn, after 691f1a2 ("replace direct calls to unlink
> (2) with unlink_or_warn")
>
> Junio: I've rebased the patch series on pu, hopefully this stops the
> attribute warnings for patch 3.
>
> Tay Ray Chuan (3):
> http*: add helper methods for fetching packs
> http*: add helper methods for fetching objects/info/packs
> http*: add helper methods for fetching objects (loose)I do think these would be even better if they were integrated with http://kerneltrap.org/mailarchive/git/2009/1/18/4757804.
Speaking of which, do we have a better http test suite now ? If we do, I can try to (finally) finalize my work.
Mike