git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [JGIT PATCH] Fix data corruption in DirCacheIterator when EmptyTreeIterator is used

From
Shawn O. Pearce <spearce@spearce.org>
Date
May 11, 2009, 19:44 UTC
Message-ID
<20090511194429.GM30527@spearce.org>
In-Reply-To
<200905112059.58212.robin.rosenberg.lists@dewire.com>
Robin Rosenberg <robin.rosenberg.lists@dewire.com> wrote:
> 
> Shouldn't we update some unit tests too? The dircache must be reliable.
I see you ignored the remark I put in the cover letter below the ---.

I think we should have unit tests too. I just can't come up with a way test the fix to prevent regression. And I don't have any more time for it probably the rest of this week. I'd rather have the corruption fix in the tree with no test than continue to have surprising corruption under certain cases. But if you or Mark can offer a test, I'd love to have it.

-- 
Shawn.
Previous: Robin Rosenberg
Message 3 of 3 in “Fix data corruption in DirCacheIterator when EmptyTreeIterator is used”
  1. Fix data corruption in DirCacheIterator when EmptyTreeIterator is usedShawn O. Pearce, May 11, 2009
  2. Robin RosenbergMay 11, 2009
  3. Shawn O. PearceMay 11, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.