Re: [PATCH] Create $GIT_DIR/objects/pack if missing during renameAndOpenPack

From: Robin Rosenberg <robin.rosenberg.lists@dewire.com>
Date: May 10, 2009, 22:59 UTC
Message-ID: <200905110059.50494.robin.rosenberg.lists@dewire.com>
In-Reply-To: <20090510213046.GC30527@spearce.org>

söndag 10 maj 2009 23:30:46 skrev "Shawn O. Pearce" <spearce@spearce.org>:

Show 9 quoted lines

> diff --git a/org.spearce.jgit/src/org/spearce/jgit/transport/IndexPack.java b/org.spearce.jgit/src/org/spearce/jgit/transport/IndexPack.java
> index b2bcbb7..1eb40d4 100644
> --- a/org.spearce.jgit/src/org/spearce/jgit/transport/IndexPack.java
> +++ b/org.spearce.jgit/src/org/spearce/jgit/transport/IndexPack.java
> @@ -1037,6 +1037,14 @@ public PackLock renameAndOpenPack(final String lockMessage)
>  		final File finalIdx = new File(packDir, "pack-" + name + ".idx");
>  		final PackLock keep = new PackLock(finalPack);
>  
> +		if (!packDir.exists() && !packDir.mkdir() && !packDir.exists()) {

Is there a lot to gain by this instead of just if (!packDir.mkdir() && !packDir.exists()) ?

-- robin