Re: [PATCH v2] git-svn: add --authors-prog option

From: Eric Wong <normalperson@yhbt.net>
Date: May 10, 2009, 00:35 UTC
Message-ID: <20090510003509.GA2000@dcvr.yhbt.net>
In-Reply-To: <ca433830905082048u6088a58ai16b1c979ef742f7@mail.gmail.com>

Mark Lodato <lodatom@gmail.com> wrote:

Show 6 quoted lines

> On Fri, May 8, 2009 at 3:43 AM, Michael J Gruber
> <git@drmicha.warpmail.net> wrote:
> > Mark Lodato venit, vidit, dixit 08.05.2009 03:11:
> > Maybe we want a config key also, just like for the authors file.
> 
> Yes, this is a very good idea.  I will figure out how to do this.

It already works :) Command-line options taken by git svn have always been automatically converted to config keys.

Show 12 quoted lines

> > The feature itself looks useful for large user databases. For smaller
> > ones one could just as well update the authors file before each fetch by
> > dumping the whole db in there (or even conditionally on git svn fetch
> > erroring out due to encountering an unknown name).
> 
> Right.  This feature will most likely be useful in corporate
> environments.  In my case, it is not possible to dump the entire user
> database to a file, so this patch is the only solution.  Another
> possible use case is where SVN usernames are standardized, e.g. "jdoe"
> -> "J Doe <jdoe@example.com>".  Also, using --authors-prog solves the
> problem of keeping the authors file up-to-date, if users are regularly
> added or deleted.

Thanks Mark. Your patch looks good and I'll apply the next one after the grammar fixes. I've actually thought about implementing this myself back when I (briefly) worked in a corporate environment, but never got around to it.

Sorry for the late response and not following the mailing list more closely these days.

-- 
Eric Wong