Re: [PATCH 2/2] Use NullProgressMonitor.INSTANCE and indent for loop

From: Shawn O. Pearce <spearce@spearce.org>
Date: May 6, 2009, 20:48 UTC
Message-ID: <20090506204849.GM30527@spearce.org>
In-Reply-To: <1241642224-6914-2-git-send-email-alex.blewitt@gmail.com>

Alex Blewitt <alex.blewitt@gmail.com> wrote:

> ---
>  .../src/org/spearce/jgit/lib/PackWriter.java       |   25 ++++++++++---------
>  1 files changed, 13 insertions(+), 12 deletions(-)

Also, I'd like a Signed-off-by line for your patches. We follow Linux kernel tradition and use a Signed-off-by line to mean you agree to the "Developer's Certificate of Origin 1.1" (see SUBMITTING_PATCHES in the top level directory, part 5).

For the 2 that you've submitted thus far (this one, and the make
private constructor) you can just reply to the email and drop the
SOB line into the message body.  In the future make sure you add
it in with git commit -s or git format-patch -s prior to sending.

-- 
Shawn.