Re: [JGIT PATCH 2/2] Correct Javadoc comment for TransportLocal about forking
Robin Rosenberg <robin.rosenberg.lists@dewire.com> wrote:
Show 15 quoted lines
> l?rdag 02 maj 2009 22:30:30 skrev "Shawn O. Pearce" <spearce@spearce.org>:
> > + * However, during {@link #openFetch()}, if the Transport has configured
> > + * {@link Transport#getOptionUploadPack()} to be anything other than
> > + * <code>"git-upload-pack"</code> or <code>"git upload-pack"</code>, this
> > + * implementation will fork and execute the external process, using an operating
> > + * system pipe to transfer data.
> > + * <p>
> > + * However, during {@link #openPush()}, if the Transport has configured
> > + * {@link Transport#getOptionReceivePack()} to be anything other than
> > + * <code>"git-receive-pack"</code> or <code>"git receive-pack"</code>, this
> > + * implementation will fork and execute the external process, using an operating
> > + * system pipe to transfer data.
> >
>
> I'll change the second However to Similarly. I think it reads better, even though I'm not a native English speaker.Yea, you're right, it does read better that way. Thanks!
--
Shawn.
Shawn O. Pearce <spearce@spearce.org>