git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Documentation: Fix description of archive "--prefix"

From
Wesley J. Landaker <wjl@icecavern.net>
Date
Apr 30, 2009, 02:33 UTC
Message-ID
<200904292033.03899.wjl@icecavern.net>
In-Reply-To
<20090429154941.GB33221014@CIS.FU-Berlin.DE>
On Wednesday 29 April 2009 09:49:41 Holger Weiß wrote:
Show 7 quoted lines
> * Holger Weiß <holger@zedat.fu-berlin.de> [2009-04-29 15:42]:
> > The description of the "--prefix" option suggested that a slash would
> > automatically be appended to the specified <prefix>, which is not the
> > case.
>
> Nonsense, it's telling the user that appending a slash to the <prefix>
> is mandatory.  Scratch my patch.

I just tried not using a slash; it doesn't give an error or internally add one, instead it makes a worthless archive:

$ git archive --prefix=noslash HEAD | tar tv | head -rw-rw-r-- root/root 51 2009-04-28 01:46 noslash.gitattributes -rw-rw-r-- root/root 2416 2009-04-28 01:46 noslash.gitignore -rw-rw-r-- root/root 2519 2009-04-28 01:46 noslash.mailmap -rw-rw-r-- root/root 18787 2009-04-28 01:46 noslashCOPYING drwxrwxr-x root/root 0 2009-04-28 01:46 noslashDocumentation/ -rw-rw-r-- root/root 17 2009-04-28 01:46 noslashDocumentation/.gitattributes -rw-rw-r-- root/root 91 2009-04-28 01:46 noslashDocumentation/.gitignore -rw-rw-r-- root/root 4868 2009-04-28 01:46 noslashDocumentation/CodingGuidelines -rw-rw-r-- root/root 9028 2009-04-28 01:46 noslashDocumentation/Makefile -rw-rw-r-- root/root 1255 2009-04-28 01:46 noslashDocumentation/RelNotes-1.5.0.1.txt

Should this be fixed by automatically adding a slash if there wasn't one given? I can't image anyone would want an archive made of mangled filenames like this, so if we don't want that behavior, it seems like it should at least give an error.

Previous: Holger Weiß
Message 3 of 3 in “Documentation: Fix description of archive "--prefix"”
  1. Documentation: Fix description of archive "--prefix"Holger Weiß, Apr 29, 2009
  2. Holger WeißApr 29, 2009
  3. Wesley J. LandakerApr 30, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.