git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] gitweb: escape searchtext and parameters for replay

From
Jakub Narebski <jnareb@gmail.com>
Date
Apr 29, 2009, 13:14 UTC
Message-ID
<200904291514.11331.jnareb@gmail.com>
In-Reply-To
<0626233F-50D5-4F7E-9009-506FEA77571D@aepfle.de>
On Wed, 29 Apr 2009, Olaf Hering wrote:
Show 10 quoted lines
> Am 29.04.2009 um 14:28 schrieb Jakub Narebski: 
>> On Wed, 29 April 2009, Michael J Gruber wrote:
> 
>>>> It should be s=torvalds%40linux instead of s=torvalds\@linux
>>
>> If you by hand edit URL changing '\@' to simply '@', does changed
>> gitweb URL works correctly?
> 
> I tried akpm@osdl.org, and @ and . was escaped with a backslash.
> Removing both, and using the plain mail address worked.

This problem was fixed in 7e431ef (gitweb: Separate search regexp from search text), but this fix is present in git 1.5.2 and later, and kernel.org gitweb is a fork (adding caching mechanism) of 1.4.5-rc0, according to info in git.kernel.org HTML source, and it does not have this fix.

  http://git.kernel.org/?p=git/warthog9/gitweb.git;a=summary
I have CC-ed J.H. on this.
-- 
Jakub Narebski
Poland
Previous: Olaf HeringNext: Jakub Narebski
Message 5 of 9 in “Invalid search parameter in webinterface”
  1. Olaf HeringApr 29, 2009
  2. gitweb: escape searchtext and parameters for replayMichael J Gruber, Apr 29, 2009
  3. Jakub NarebskiApr 29, 2009
  4. Olaf HeringApr 29, 2009
  5. Jakub NarebskiApr 29, 2009
  6. Jakub NarebskiApr 29, 2009
  7. Michael J GruberApr 29, 2009
  8. J.H.Apr 29, 2009
  9. gitweb: Separate search regexp from search textJakub Narebski, Apr 30, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.