Re: [EGit PATCH] IgnoreAction to add to .gitignore files

From: Robin Rosenberg <robin.rosenberg@dewire.com>
Date: Apr 23, 2009, 19:19 UTC
Message-ID: <200904232119.36707.robin.rosenberg@dewire.com>
In-Reply-To: <0A94BEDB-37A1-44D2-BE54-D05F0C3124EE@bandlem.com>

torsdag 23 april 2009 14:32:46 skrev Alex Blewitt <alex@bandlem.com>:

Show 9 quoted lines

> Actually, that's pretty much exactly the format that Eclipse users  
> will be expecting.
> 
> CVS: Add to .cvsignore
> SVN: Add to svn:ignore
> 
> I suggest that we go with that style of format for the menu items, in  
> order to achieve consistency with the way that the other team  
> providers work.

Ouch, top posting....

Anyway, I agree with Alex. My motivation is that there are more than one way to specify ignore. There's .gitignore, .git/info/excludedes and the Team ignore settings themselves. This option specifically messes with .gitignore.

-- robin

Show 47 quoted lines

> Note also that the tooltip is usually much shorter than that ... it's  
> not a full help description, it explains what it does.
> 
> Alex
> 
> On 23 Apr 2009, at 13:27, Francis Galiegue wrote:
> 
> > Le jeudi 23 avril 2009, Alex Blewitt a écrit :
> >> diff --git a/org.spearce.egit.ui/plugin.properties
> > b/org.spearce.egit.ui/plugin.properties
> >> index 523a959..be3b40c 100644
> >> --- a/org.spearce.egit.ui/plugin.properties
> >> +++ b/org.spearce.egit.ui/plugin.properties
> >> @@ -52,10 +52,12 @@ FetchAction_tooltip=Fetch from another repository
> >> PushAction_label=&Push To...
> >> PushAction_tooltip=Push to another repository
> >>
> >> +IgnoreAction_label=Add to .git&ignore...
> >> +IgnoreAction_tooltip=Ignore the selected resources
> >> +
> >> GitActions_label=Git
> >> GitMenu_label=&Git
> >>
> >
> > The label and tooltip are too "git-specific", IMHO. I'd rather see:
> >
> > IgnoreAction_label=&Ignore file(s) for commits...
> > IgnoreAction_tooltip=The selected file(s) will not be included by  
> > default in
> > your commits. However, you may force the include of these files in a  
> > commit
> > by explicitly adding them via "Team->Add" [or whatever the label is].
> > \n\nSelecting files to ignore by this mechanism will automatically  
> > add one or
> > more files named .gitignore in your next commit.
> >
> > -- 
> > Francis Galiegue
> > ONE2TEAM
> > Ingénieur système
> > Mob : +33 (0) 683 877 875
> > Tel : +33 (0) 178 945 552
> > fge@one2team.com
> > 40 avenue Raymond Poincaré
> > 75116 Paris
> 
>