Re: [PATCH] grep: don't support "grep.color"-like config options

From: Markus Heidelberg <markus.heidelberg@web.de>
Date: Apr 21, 2009, 00:11 UTC
Message-ID: <200904210211.52818.markus.heidelberg@web.de>
In-Reply-To: <alpine.DEB.1.00.0904210145260.10279@pacific.mpi-cbg.de>

Johannes Schindelin, 21.04.2009:

Show 10 quoted lines

> Hi,
> 
> On Tue, 21 Apr 2009, Markus Heidelberg wrote:
> 
> > color.grep and color.grep.* is the official and documented way to 
> > highlight grep matches. Comparable options like diff.color.* and 
> > status.color.* exist for backward compatibility reasons only and are not 
> > documented any more.
> 
> But is it really so bad that we have to possibly break existing setups?

Given that they have never been documented since introduction of "grep --color" in March, wouldn't it be pure luck from a users' POV, that they even worked, after the user accidentally typed grep.color instead of color.grep with git-config? Should we then also introduce branch.color afterwards?

Also, colorized grep isn't yet released, people currently using grep.color (and I guess they are very few, if any) normally are compiling git on their own and shouldn't have problems with it disappearing.

> The cost of keeping them is really small IMHO.

Maybe, but it's always nice to keep things simpler and cleaner.

Markus