Re: [EGIT PATCH] Add support for writing/appending .gitignore file

From: Robin Rosenberg <robin.rosenberg.lists@dewire.com>
Date: Apr 20, 2009, 06:32 UTC
Message-ID: <200904200832.28361.robin.rosenberg.lists@dewire.com>
In-Reply-To: <636fd28e0904191940t3476b016qc76c0e1e624f7b37@mail.gmail.com>

måndag 20 april 2009 04:40:42 skrev Alex Blewitt <alex.blewitt@gmail.com>:

Show 15 quoted lines

> On Sun, Apr 19, 2009 at 10:50 PM, Robin Rosenberg
> <robin.rosenberg.lists@dewire.com> wrote:
> >
> > First, Ferry Huberts is also working on a solution for ignore See
> > http://thread.gmane.org/gmane.comp.version-control.git/114825 though you
> > focus on different aspects.
> 
> Yup, saw the issue 32. I'll keep an eye on that and hopefully I can
> leverage what that does when it's ready.
> 
> > This patch is whitespace damaged. Â Pasting into gmail won't work. Gmail
> > has authenticated SMTP on port 25 and 465 (SSL) so git-send-email should work that way.
> 
> One advantage of attaching issues is you don't have MUA problems :-)
> I'll try and get a patch to work via git-send-email later.

The problem is review. With e-mail I can just hit reply and comment on your patch. Did your try the SMTP interface to gmail? I think e-mailing inlined patches is a nearly perfect. Inline-attachment is ok with me. That makes it possible to comment on them like any email in my mail program.

> I've been incrementally committing to my local git copy. Whenever I do
> git format-patch <since> it spews out individual patchettes. How can I
> use git to generate one patch? I could git diff <since>, but that's
> not following the SUBMITTING_PATCHES, is it?

Often, after a long session, you end up with a "mess" of commits, many which don't make sense to anyone but you. For this you use rebase -i to clean up. It allows you to reorder, squash and edit commits. You'll end up with an entirely new version of your branch. Retest to make sure it's ok and submit.

-- robin