git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Allow git-shell to be used as a ssh forced-command

From
Mike Hommey <mh@glandium.org>
Date
Apr 18, 2009, 06:31 UTC
Message-ID
<20090418063100.GA18568@glandium.org>
In-Reply-To
<20090417234859.GY898@eagain.net>
On Fri, Apr 17, 2009 at 04:48:59PM -0700, Tommi Virtanen wrote:
Show 13 quoted lines
> On Fri, Apr 17, 2009 at 04:40:54PM -0700, Junio C Hamano wrote:
> > How does this interact with a typical gitosis installation?  I think it
> > extracts bits from the ORIGINAL_COMMAND and formulates a sanitized command
> > line and then passes it to git-shell but I do not think it removes the
> > variable from the environment.
> 
> Yup, not sanitizing. I could make that change easily, if you want, but
> there's plenty of installations out there already.
> 
> I'd say add a git-shell flag that enables any magic behavior, don't
> just magically work differently based on that environment variable.
> Sometimes that is set for reasons that are not related to what you're
> actually running in the end; e.g. "chroot /foo exec-whatever-i-gave-you".

What about triggering only when there is no option at all? Doing so would normally terminate git-shell telling the user it's not a shell.

Mike
Previous: Junio C HamanoNext: Mike Hommey
Message 12 of 18 in “Allow git-shell to be used as a ssh forced-command”
  1. Allow git-shell to be used as a ssh forced-commandMike Hommey, Apr 16, 2009
  2. Dmitry PotapovApr 17, 2009
  3. Mike HommeyApr 17, 2009
  4. Dmitry PotapovApr 17, 2009
  5. Mike HommeyApr 17, 2009
  6. Shawn O. PearceApr 17, 2009
  7. Mike HommeyApr 17, 2009
  8. Matthieu MoyApr 18, 2009
  9. Junio C HamanoApr 17, 2009
  10. Tommi VirtanenApr 17, 2009
  11. Junio C HamanoApr 18, 2009
  12. Mike HommeyApr 18, 2009
  13. Allow git-shell to be used as a ssh forced-commandMike Hommey, Apr 21, 2009
  14. Dmitry PotapovApr 21, 2009
  15. Eygene RyabinkinApr 21, 2009
  16. Junio C HamanoApr 21, 2009
  17. Mike HommeyApr 21, 2009
  18. Dmitry PotapovApr 21, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.