git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 4/5] archive: do not read .gitattributes in working directory

From
Jeff King <peff@peff.net>
Date
Apr 16, 2009, 07:06 UTC
Message-ID
<20090416070626.GB20071@coredump.intra.peff.net>
In-Reply-To
<7vhc0pnpn3.fsf@gitster.siamese.dyndns.org>
On Wed, Apr 15, 2009 at 10:17:36PM -0700, Junio C Hamano wrote:
Show 13 quoted lines
> > +	/* tar-tree defaults to fix-attributes as before */
> > +	nargv[nargc++] = "--fix-attributes";
> > +
> >  	switch (argc) {
> >  	default:
> >  		usage(tar_tree_usage);
> 
> I screwed up this part; nargv[] array needs to be enlarged by one element
> because of this change.  It resulted in a funny breakage in tests that
> triggered only when run from the toplevel of the tree but did not surface
> when the individual test was done from t/ directory, which my final
> testing on the k.org machine caught, and that is why I still haven't
> managed to push the result out for tonight.

FWIW, running t5000 with --valgrind does catch it. I'll try to run the full test suite with valgrind on the last -rc before 1.6.3 to catch any hidden issues which have cropped up during this cycle (I can do it earlier, too, but it is a real pain to run the whole thing, so I want to just wait until the last minute).

-Peff
Previous: Junio C HamanoNext: Jakub Narebski
Message 9 of 19 in “archive attribute series”
  1. 0/5 archive attribute seriesJunio C Hamano, Apr 16, 2009
  2. 1/5 archive tests: do not use .gitattributes in working directoryJunio C Hamano, Apr 16, 2009
  3. 2/5 attr: add GIT_ATTR_INDEX "direction"Junio C Hamano, Apr 16, 2009
  4. 3/5 unpack-trees: do not muck with attributes when we are not checking outJunio C Hamano, Apr 16, 2009
  5. 4/5 archive: do not read .gitattributes in working directoryJunio C Hamano, Apr 16, 2009
  6. 5/5 archive test: test new --fix-attributes featureJunio C Hamano, Apr 16, 2009
  7. René ScharfeApr 17, 2009
  8. Junio C HamanoApr 16, 2009
  9. Jeff KingApr 16, 2009
  10. Jakub NarebskiApr 16, 2009
  11. Nguyen Thai Ngoc DuyApr 16, 2009
  12. Nguyen Thai Ngoc DuyApr 16, 2009
  13. René ScharfeApr 17, 2009
  14. René ScharfeApr 17, 2009
  15. 1/5 archive tests: do not use .gitattributes in working directoryRené Scharfe, Apr 17, 2009
  16. 2/5 attr: add GIT_ATTR_INDEX "direction"René Scharfe, Apr 17, 2009
  17. 3/5 unpack-trees: do not muck with attributes when we are not checking outRené Scharfe, Apr 17, 2009
  18. 4/5 archive: do not read .gitattributes in working directoryRené Scharfe, Apr 17, 2009
  19. 5/5 archive test: attributesRené Scharfe, Apr 17, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.