git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] git-shell: Add 'git-upload-archive' to allowed commands.

From
Björn Steinbrink <b.steinbrink@gmx.de>
Date
Apr 14, 2009, 06:09 UTC
Message-ID
<20090414060927.GA3948@atjola.homenet>
In-Reply-To
<7v3acff10x.fsf@gitster.siamese.dyndns.org>
On 2009.04.11 12:22:54 -0700, Junio C Hamano wrote:
Show 21 quoted lines
> Erik Broes <erikbroes@ripe.net> writes:
> 
> > This allows for example gitosis to allow use of 'git archive --remote' in a
> > controlled environment.
> >
> > Signed-off-by: Erik Broes <erikbroes@ripe.net>
> > ---
> >
> > There were some questions on IRC raising (valid) concerns about security.
> > If there is a dangling commit on the remote end and any user would know
> > or guess the SHA, it could be retrieved where git-upload-pack will not
> > allow so.
> >
> > We were unable to find out if this was the original reason git-shell was
> > never extended with git-upload-archive functionality or if it was a simple
> > oversight. If it was the reason I'm not sure there is an easy way out.
> 
> Can't the "security concern" be addressed by whatever creates the
> controlled environment (e.g. gitosis)?  For example, git-daemon can be
> configured to service upload-archive request, so I do not think it is such
> a bad idea to make this available if the site owner wants to use it.

But what about users that just have their shell set to git-shell? IIRC around 1.6.0 we had some reports about broken setups because git-shell had been moved to libexec. So apparently there are such setups, and the change would weaken the restrictions for them.

Hm? Björn

Previous: Erik Broes
Message 4 of 4 in “git-shell: Add 'git-upload-archive' to allowed commands.”
  1. git-shell: Add 'git-upload-archive' to allowed commands.Erik Broes, Apr 9, 2009
  2. Junio C HamanoApr 11, 2009
  3. Erik BroesApr 12, 2009
  4. Björn SteinbrinkApr 14, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.