git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v4 14/14] difftool/mergetool: refactor commands to use git-mergetool--lib

From
Charles Bailey <charles@hashpling.org>
Date
Apr 8, 2009, 06:40 UTC
Message-ID
<20090408064037.GA9372@hashpling.org>
In-Reply-To
<7vtz4zr80v.fsf@gitster.siamese.dyndns.org>
On Tue, Apr 07, 2009 at 11:09:36PM -0700, Junio C Hamano wrote:
Show 6 quoted lines
> Markus Heidelberg <markus.heidelberg@web.de> writes:
> > Looks good to me, after these last 2 issues are adjusted.
> > Maybe resend the whole series then, so that Junio can apply them easily?
> 
> Thanks.  I've replaced the series with the following applied on top of the
> 'master', but I won't be merging them to 'next' for tonight, I guess.

I feel I should be re-reviewing the mergetool patches, but while I have sufficient time, it is usually at the weekend so I can't always respond very rapidly.

I have been skimming this series, but most of the times that I thought I could apply the series and have a thorough review, another comment and re-roll has come through and I've decided to wait until it's stable.

My slight concern is that this series has been changing very rapidly, is everyone else happy that it is stable enough for merge into next? Would you like my further input?

Charles.
Previous: David AguilarNext: Junio C Hamano
Message 5 of 6 in “difftool/mergetool: refactor commands to use git-mergetool--lib”
  1. 14/14 difftool/mergetool: refactor commands to use git-mergetool--libDavid Aguilar, Apr 7, 2009
  2. Markus HeidelbergApr 8, 2009
  3. Junio C HamanoApr 8, 2009
  4. David AguilarApr 8, 2009
  5. Charles BaileyApr 8, 2009
  6. Junio C HamanoApr 8, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.