Re: Broken umlaut in my name, again

From: Björn Steinbrink <b.steinbrink@gmx.de>
Date: Apr 6, 2009, 13:17 UTC
Message-ID: <20090406131747.GH20356@atjola.homenet>
In-Reply-To: <adf1fd3d0904060546j6c2fbba9r75829f2bd383458b@mail.gmail.com>

On 2009.04.06 14:46:43 +0200, Santi Béjar wrote:

Show 21 quoted lines

> 2009/4/6 Björn Steinbrink <B.Steinbrink@gmx.de>:
> > On 2009.03.31 17:30:39 +0200, Björn Steinbrink wrote:
> >> While it makes no sense to map some email address to an empty one, doing
> >> things the other way around can be useful. For example when using
> >> filter-branch with an env-filter that employs a mailmap to fix up an
> >> import that created such broken commits with empty email addresses.
> >>
> >> Signed-off-by: Björn Steinbrink <B.Steinbrink@gmx.de>
> >
> > The umlaut (ö) in my name is broken in the commit that made it into
> > git.git --> 5288dd58356e53d61e2b3804fc7d8d23c3a46ab3
> >
> > Last time this happened when I used format-patch -s instead of commit -s
> > IIRC. But since then, I pay attention to do the sign-off via commit -s,
> > yet my name is broken again. What did I do wrong this time?
> 
> I don't see nothing wrong in your mails. It appears to be a double
> conversion to UTF-8 between the mail and the commit.
> 
> But I always use format-patch -s without problems, what was your
> problem with format-patch?

I don't recall the exact problem, and I can't find the mails anymore, the IIRC it was something about Content-type being generated from the original commit message, and only afterwards the sign-off line got added, or something like that. That causes the Content-type to say ascii, although the sign-off had UTF-8 in it. Or something like that. Might very well have been fixed since then (it was almost 2 years ago that I hit that bug IIRC), but it made me stick to commit -s ;-)

Björn