git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Add warning about known issues to documentation of cvsimport

From
Heiko Voigt <hvoigt@hvoigt.net>
Date
Mar 31, 2009, 16:22 UTC
Message-ID
<20090331162103.GA72569@macbook.lan>
In-Reply-To
<49D1ABD0.8070707@pelagic.nl>
On Tue, Mar 31, 2009 at 07:36:16AM +0200, Ferry Huberts (Pelagic) wrote:
Show 18 quoted lines
> Heiko Voigt wrote:
> > On Mon, Mar 23, 2009 at 09:33:55PM +0100, Ferry Huberts (Pelagic) wrote:
> >> maybe you can also add remarks about autocrlf and safecrlf?
> >> both need to be off
> > 
> > From my experience thats not necessarily true. You can use
> > autocrlf=input to repair broken revisions were crlf's have been
> > mistakenly committed into the repository. And if I remember correctly
> > safecrlf helps if you want to make sure that no information gets lost.
> > 
> > So when importing from a nice correct cvs repository you would expect
> > safecrlf to not stop your import. And I suspect there are actually cvs
> > users that were very careful with their lineendings who would use it.
> > 
> > cheers Heiko
> If you look at this thread:
> http://thread.gmane.org/gmane.comp.version-control.git/110152/focus=110358
> you'll see why I said it. I did some testing to prove my statement.

Well, from that thread I see my statement supported. It is not true that they *need* to be off. Maybe a statement that certain crlf settings are exclusive would be good, but I agree that should go into the config documentation.

The main point I see here is that the User may not be aware that such a conversion is applied so something like this could help.

cheers Heiko
diff --git a/Documentation/git-cvsimport.txt b/Documentation/git-cvsimport.txt
index e1fd047..d4e7fd4 100644
--- a/Documentation/git-cvsimport.txt
+++ b/Documentation/git-cvsimport.txt
@@ -40,6 +40,11 @@ probably want to make a bare clone of the imported repository
 and use the clone as the shared repository.
 See linkgit:gitcvs-migration[7].
 
+Note: All revisions are imported using the index so settings of
+core.autocrlf and core.safecrlf are applied. This way you can change or
+safety check the import. If you do not want this make sure these options
+are both set to false.
+
 
 OPTIONS
 -------
Previous: Ferry Huberts (Pelagic)Next: Heiko Voigt
Message 5 of 22 in “Add warning about known issues to documentation of cvsimport”
  1. Add warning about known issues to documentation of cvsimportHeiko Voigt, Mar 23, 2009
  2. Ferry Huberts (Pelagic)Mar 23, 2009
  3. Heiko VoigtMar 30, 2009
  4. Ferry Huberts (Pelagic)Mar 31, 2009
  5. Heiko VoigtMar 31, 2009
  6. cvsimport: Add a note about crlf options to the documentationHeiko Voigt, Mar 31, 2009
  7. Ferry Huberts (Pelagic)Mar 31, 2009
  8. Jeff KingMar 24, 2009
  9. Heiko VoigtMar 30, 2009
  10. Junio C HamanoMar 31, 2009
  11. Cleanup warning about known issues in cvsimport documentationHeiko Voigt, Mar 31, 2009
  12. Jeff KingMar 31, 2009
  13. Cleanup warning about known issues in cvsimport documentationHeiko Voigt, Apr 1, 2009
  14. Jeff KingMar 31, 2009
  15. Jeff KingMar 31, 2009
  16. Junio C HamanoMar 31, 2009
  17. Documentation: use "spurious .sp" XSLT if DOCBOOK_SUPPRESS_SP is setChris Johnsen, Apr 1, 2009
  18. Jeff KingApr 1, 2009
  19. Junio C HamanoApr 2, 2009
  20. Jeff KingApr 1, 2009
  21. Chris JohnsenApr 1, 2009
  22. Jeff KingApr 1, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.