git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] test-lib: Clean up comments and Makefile.

From
Emil Sit <sit@emilsit.net>
Date
Mar 28, 2009, 01:57 UTC
Message-ID
<20090328015718.GD6538@cauchy-sequence.lcs.mit.edu>

Bring documentation in test-lib and clean target in Makefile in-line with abc5d372.

Signed-off-by: Emil Sit <sit@emilsit.net>
---
 t/Makefile    |    2 +-
 t/test-lib.sh |    8 --------
 2 files changed, 1 insertions(+), 9 deletions(-)
diff --git a/t/Makefile b/t/Makefile
index 0962341..bf816fc 100644
--- a/t/Makefile
+++ b/t/Makefile
@@ -24,7 +24,7 @@ pre-clean:
 	$(RM) -r test-results
 
 clean:
-	$(RM) -r 'trash directory' test-results
+	$(RM) -r 'trash directory'.* test-results
 
 aggregate-results-and-cleanup: $(T)
 	$(MAKE) aggregate-results
diff --git a/t/test-lib.sh b/t/test-lib.sh
index 2979e8e..b050196 100644
--- a/t/test-lib.sh
+++ b/t/test-lib.sh
@@ -523,14 +523,6 @@ test_done () {
 	fi
 	case "$test_failure" in
 	0)
-		# We could:
-		# cd .. && rm -fr 'trash directory'
-		# but that means we forbid any tests that use their own
-		# subdirectory from calling test_done without coming back
-		# to where they started from.
-		# The Makefile provided will clean this test area so
-		# we will leave things as they are.
-
 		say_color pass "passed all $msg"
 
 		test -d "$remove_trash" &&
-- 
1.5.4.3

-- 
Emil Sit / http://www.emilsit.net/
Message 1 of 1 in “test-lib: Clean up comments and Makefile.”
  1. test-lib: Clean up comments and Makefile.Emil Sit, Mar 28, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.