Re: [PATCH] difftool: add support for an extended revision syntax

From: David Aguilar <davvid@gmail.com>
Date: Mar 27, 2009, 18:16 UTC
Message-ID: <20090327181547.GA4933@gmail.com>
In-Reply-To: <7vab76evaj.fsf@gitster.siamese.dyndns.org>

On  0, Junio C Hamano <gitster@pobox.com> wrote:

Show 7 quoted lines

> David Aguilar <davvid@gmail.com> writes:
> 
> > I noticed that my patches for "add tests to difftool" and "add
> > the -y shortcut for --no-prompt" were in git.git's pu branch
> > the other day but aren't there anymore.  Was that intentional?
> 
> Yes, it makes 'pu' not pass the self test.

Oops, was this related to your suggestions about the patch that added the tests? I sent a v2 patch that included the fixups. I'll try running the tests when I get back home to my Linux machine on Monday (I'm currently in Chicago on a trip) though I'm not sure if I'd be able to reproduce the failure if it's platform-specific.

Sorry 'bout that.

-- 
	David