git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: patch series starting with [JGIT PATCH 1/5] Remove dead/unused reset method from CountingOutputStream

From
Shawn O. Pearce <spearce@spearce.org>
Date
Mar 27, 2009, 14:51 UTC
Message-ID
<20090327145100.GM23521@spearce.org>
In-Reply-To
<200903270911.54571.robin.rosenberg.lists@dewire.com>
Robin Rosenberg <robin.rosenberg.lists@dewire.com> wrote:
> 
> More related, I also noted that the git:// ssh or file: clone calculates the CRC's separately
> and wasn't subject to this bug.

clone (or fetch) is going through IndexPack, which has its own logic to tear apart a pack file and build up the table of contents of that pack in the most efficient method possible. Its an entirely different code base than writing a pack, because its going the other direction. :-)

The new test case at least validates that both IndexPack and PackWriter produce the same information in the .idx file.

-- 
Shawn.
Previous: Robin RosenbergNext: Shawn O. Pearce
Message 9 of 11 in “Remove dead/unused reset method from CountingOutputStream”
  1. 1/5 Remove dead/unused reset method from CountingOutputStreamShawn O. Pearce, Mar 26, 2009
  2. 2/5 Implement CRC32 computation during PackWriterShawn O. Pearce, Mar 26, 2009
  3. 3/5 Test case for pack index CRC32 when written by PackWriterShawn O. Pearce, Mar 26, 2009
  4. 4/5 Write the pack header in one shotShawn O. Pearce, Mar 26, 2009
  5. 5/5 Use Deflater directly in PackWriterShawn O. Pearce, Mar 26, 2009
  6. Daniel ChengMar 26, 2009
  7. Daniel ChengMar 26, 2009
  8. Robin RosenbergMar 27, 2009
  9. Shawn O. PearceMar 27, 2009
  10. Shawn O. PearceMar 27, 2009
  11. Robin RosenbergMar 27, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.