Re: [StGit PATCH] Add the --merged option to goto

From: Karl Hasselström <kha@treskal.com>
Date: Mar 26, 2009, 11:15 UTC
Message-ID: <20090326111554.GA19337@diana.vm.bytemark.co.uk>
In-Reply-To: <b0943d9e0903250324j9ed0ed9k2d97cbacba6a7801@mail.gmail.com>

On 2009-03-25 10:24:13 +0000, Catalin Marinas wrote:

> BTW, why don't we keep the tree information directly in the Index
> object? Since this object is modified only via its own interface, it
> can do all the checks and avoid the managing of temp_index_tree in
> the Transaction object.

I guess that might be a good idea -- it should be doable without any extra overhead for users that don't want it.

> Yes. But it may be even better to do this in Index.
> Index.apply_treediff() would set the tree to None and read_tree or
> write_tree would set it to the corresponding tree.

We'd have to cover the other index operations too. But yes, this is probably a good idea.

> >  3. Why are empty patches considered not merged?
>
> They would be reported as empty anyway and in general you don't
> submit empty patches for upstream merging.

Ah, duh. I was forgetting what the "merged" detection was for in the first place.

-- 
Karl Hasselström, kha@treskal.com
      www.treskal.com/kalle