git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 05/10] rev-list: make "show_bisect_vars" non static

From
Christian Couder <chriscool@tuxfamily.org>
Date
Mar 26, 2009, 04:55 UTC
Message-ID
<20090326055535.9b970cff.chriscool@tuxfamily.org>
and declare it in "bisect.h" as we will use this function later.

While at it, rename its last argument "show_all" instead of "bisect_find_all".

Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
---
 bisect.h           |    2 ++
 builtin-rev-list.c |    5 +++--
 2 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/bisect.h b/bisect.h
index 60b2fe1..860a15c 100644
--- a/bisect.h
+++ b/bisect.h
@@ -5,4 +5,6 @@ extern struct commit_list *find_bisection(struct commit_list *list,
 					  int *reaches, int *all,
 					  int find_all);
 
+extern int show_bisect_vars(int reaches, int all, int show_all);
+
 #endif
diff --git a/builtin-rev-list.c b/builtin-rev-list.c
index 74d22b4..c700c34 100644
--- a/builtin-rev-list.c
+++ b/builtin-rev-list.c
@@ -226,7 +226,7 @@ static int estimate_bisect_steps(int all)
 	return (e < 3 * x) ? n : n - 1;
 }
 
-static int show_bisect_vars(int reaches, int all, int bisect_find_all)
+int show_bisect_vars(int reaches, int all, int show_all)
 {
 	int cnt;
 	char hex[41];
@@ -246,9 +246,10 @@ static int show_bisect_vars(int reaches, int all, int bisect_find_all)
 	cnt = all - reaches;
 	if (cnt < reaches)
 		cnt = reaches;
+
 	strcpy(hex, sha1_to_hex(revs.commits->item->object.sha1));
 
-	if (bisect_find_all) {
+	if (show_all) {
 		traverse_commit_list(&revs, show_commit, show_object);
 		printf("------\n");
 	}
-- 
1.6.2.1.317.g3d804
Message 1 of 1 in “rev-list: make "show_bisect_vars" non static”
  1. 05/10 rev-list: make "show_bisect_vars" non staticChristian Couder, Mar 26, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.