Re: [PATCH] Documentation/git-filter-branch.txt: Remove unnecessary URL quoting

From: Johan Herland <johan@herland.net>
Date: Mar 22, 2009, 23:20 UTC
Message-ID: <200903230020.10128.johan@herland.net>
In-Reply-To: <200903201619.56600.trast@student.ethz.ch>

On Friday 20 March 2009, Thomas Rast wrote:

Show 15 quoted lines

> Johan Herland wrote:
> > Embedding the URL in '+++' causes AsciiDoc (v8.4.1) to generate invalid
> > XML. None of the other URLs in Git's documentation are quoted in this
> > manner. There's no reason to treat this URL differently.
>
> [...]
>
> > -* Clone it with `git clone +++file:///path/to/repo+++`.  The clone
> > +* Clone it with `git clone file:///path/to/repo`.  The clone
>
> I deliberately wrote it that way because *not* quoting it, at least on
> my box, formats the entire paragraph in monospace.  Apparently it
> treats the ` as part of an autodetected URL or some such.  This is
> independent of my choice of ASCIIDOC8 or DOCBOOK_XSL_172 settings.  Am
> I missing another flag that avoids this problem?

No, I think this is due to version differences in AsciiDoc.

> I have these packages installed from opensuse:
>   asciidoc-8.2.7-29.10

I use AsciiDoc v8.4.1 (from Arch Linux), and according to http://www.methods.co.nz/asciidoc/CHANGELOG.html there are some regression issues regarding backtick quoting and "inline literal passthrough"s when upgrading to v8.4.1. According to the changelog I should be able to revert AsciiDoc to the old behaviour by putting

  [attributes]
  no-inline-literal=

in my Documentation/asciidoc.conf. However, with this in place, I _still_ get invalid XML generated for git-filter-branch.txt... :(

So, it seems to be an AsciiDoc versioning issue. I'm not sure which of these AsciiDoc versions are preferable, of if it is possible to format the text in such a manner that it'll work in both versions.

...Johan

-- 
Johan Herland, <johan@herland.net>
www.herland.net