git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] Produce a nicer output in case of sha1_object_info failures in ls-tree -l

From
Alex Riesen <raa.lkml@gmail.com>
Date
Mar 19, 2009, 20:30 UTC
Message-ID
<20090319203002.GA31014@blimp.localdomain>

Initialize the size with 0. The error message is already printed by sha1_object_info itself. Otherwise the uninitialized size is printed, which does not make any sense at all.

Signed-off-by: Alex Riesen <raa.lkml@gmail.com>
---
 builtin-ls-tree.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/builtin-ls-tree.c b/builtin-ls-tree.c
index fca4631..a8cdafb 100644
--- a/builtin-ls-tree.c
+++ b/builtin-ls-tree.c
@@ -60,7 +60,6 @@ static int show_tree(const unsigned char *sha1, const char *base, int baselen,
 {
 	int retval = 0;
 	const char *type = blob_type;
-	unsigned long size;
 
 	if (S_ISGITLINK(mode)) {
 		/*
@@ -91,6 +90,7 @@ static int show_tree(const unsigned char *sha1, const char *base, int baselen,
 	if (!(ls_options & LS_NAME_ONLY)) {
 		if (ls_options & LS_SHOW_SIZE) {
 			if (!strcmp(type, blob_type)) {
+				unsigned long size = 0;
 				sha1_object_info(sha1, &size);
 				printf("%06o %s %s %7lu\t", mode, type,
 				       abbrev ? find_unique_abbrev(sha1, abbrev)
-- 
1.6.2.1.250.ga1458
Next: Junio C Hamano
Message 1 of 6 in “Produce a nicer output in case of sha1_object_info failures in ls-tree -l”
  1. Produce a nicer output in case of sha1_object_info failures in ls-tree -lAlex Riesen, Mar 19, 2009
  2. Junio C HamanoMar 19, 2009
  3. Alex RiesenMar 19, 2009
  4. Junio C HamanoMar 19, 2009
  5. Produce a nicer output in case of sha1_object_info failures in ls-tree -lAlex Riesen, Mar 19, 2009
  6. Junio C HamanoMar 19, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.