Re: [JGIT PATCH 3/4] Cap the number of open files in the WindowCache
- From
Shawn O. Pearce <spearce@spearce.org>
- Date
- Mar 17, 2009, 23:08 UTC
- Message-ID
- <20090317230803.GA23521@spearce.org>
- In-Reply-To
- <200903172359.32595.robin.rosenberg.lists@dewire.com>
Robin Rosenberg <robin.rosenberg.lists@dewire.com> wrote:
Show 11 quoted lines
> tisdag 17 mars 2009 02:16:09 skrev "Shawn O. Pearce" <spearce@spearce.org>: > > > If we detect a file open failure while opening a pack we halve > > the number of permitted open files and try again, [...] > > The output of getMessage isn't that simple to interpret. Here it is filename+" (Too many files open)", > and on other platforms it is probably something else. This goes for the message part of most exceptions > thrown from platform specific code like file i/o socket i/o etc. The type of exception is a FileNotFoundException, > btw. > > I wonder whether your code works on any platform.
Arrrgh. OK. Maybe scrap that part of the patch then?
Its too bad they don't have a specific type of exception for this, nor do they have a way to hold onto file descriptors under a type like a SoftReference where the runtime can whack them if you have too many.
I guess that's why Hadoop HBase just tells you to up your fd ulimit to 32767. :-)
-- Shawn.