git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Tests: use test_cmp instead of diff where possible

From
Jeff King <peff@peff.net>
Date
Mar 17, 2009, 08:28 UTC
Message-ID
<20090317082845.GH18475@coredump.intra.peff.net>
In-Reply-To
<1237124036-1348-1-git-send-email-vmiklos@frugalware.org>
On Sun, Mar 15, 2009 at 02:33:56PM +0100, Miklos Vajna wrote:
> I intentionally did not touch t5000 - using test_cmp -r works for me,
> since the default is diff -u, but that would break the setup of users
> where GIT_TEST_CMP is set to cmp.

Definitely "test_cmp -r" is a bad idea since we don't know what underlies it. But I wonder how portable "diff -r" is. Wasn't it a point of contention in the recent cvsimport tests that were added (and Michael ended up writing a mini recursive differ using some shell commands)?

OTOH, I haven't seen any complaints about it, so perhaps it is fine to leave it.

-Peff
Previous: Miklos VajnaNext: Carlos Rica
Message 4 of 6 in “Tests: use test_cmp instead of diff where possible”
  1. Tests: use test_cmp instead of diff where possibleMiklos Vajna, Mar 15, 2009
  2. René ScharfeMar 15, 2009
  3. Tests: use test_cmp instead of diff where possibleMiklos Vajna, Mar 16, 2009
  4. Jeff KingMar 17, 2009
  5. Carlos RicaMar 17, 2009
  6. Miklos VajnaMar 17, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.