git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [JGIT PATCH 3/3] Use a common skipObject method to avoid UNINTERESTING items

From
Robin Rosenberg <robin.rosenberg.lists@dewire.com>
Date
Mar 15, 2009, 00:25 UTC
Message-ID
<200903150125.56987.robin.rosenberg.lists@dewire.com>
In-Reply-To
<1236967912-15088-3-git-send-email-spearce@spearce.org>
fredag 13 mars 2009 19:11:52 skrev "Shawn O. Pearce" <spearce@spearce.org>:
> All cases are using the same logic to decide that we should skip
> this current object and not return it to the caller.  A common
> implementation makes the code easier to follow, especially as it
> reduces the ugly line wrap involved in the loop body.

Java conventions dictate that this method should be called shouldSkipObject. It is a boolean method that actually does not itself skip any objects.

I can amend that for you.
-- robin
Previous: Shawn O. PearceNext: Shawn O. Pearce
Message 4 of 6 in “Add lookupBlob to RevWalk”
  1. 1/3 Add lookupBlob to RevWalkShawn O. Pearce, Mar 13, 2009
  2. 2/3 Fix ObjectWalk to handle single-entry subtrees correctlyShawn O. Pearce, Mar 13, 2009
  3. 3/3 Use a common skipObject method to avoid UNINTERESTING itemsShawn O. Pearce, Mar 13, 2009
  4. Robin RosenbergMar 15, 2009
  5. Shawn O. PearceMar 16, 2009
  6. Shawn O. PearceMar 13, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.