Re: [PATCH JGIT] Add "compare with Git Index" action.

From: Robin Rosenberg <robin.rosenberg.lists@dewire.com>
Date: Mar 13, 2009, 22:26 UTC
Message-ID: <200903132326.49876.robin.rosenberg.lists@dewire.com>
In-Reply-To: <551f769b0903130328g49ce9971t53e1571d1b7de06c@mail.gmail.com>

fredag 13 mars 2009 11:28:48 skrev Yann Simon <yann.simon.fr@gmail.com>:

> 2009/3/11 Robin Rosenberg <robin.rosenberg.lists@dewire.com>:
> > Saving works, but the diff regions aren't updated on save.
> 
> Sorry, I do not understand. Can you explain me more?

The compare ui marks the hunks when you bring it up. I think it should update on save to the same view you would see when it is first brought up.

Show 8 quoted lines

> > When there is a diff
> > this would give us the partial staging similar to git gui, if only (not your fault) the
> > commit dialog would allow us to make a distinction between changes in the
> > workdir and the index.
> 
> Yes, I know that this patch is not very usefull for the moment.
> I was more looking for a review as an inclusion.
> And you found one bug. Thank you for that!

Well it is, sort of though it's not *the* solution.

-- robin