git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] [TopGit] Portability: Don't use alternation ("|") in sed regular expressions

From
Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Date
Mar 12, 2009, 15:09 UTC
Message-ID
<20090312150923.GB14521@pengutronix.de>
In-Reply-To
<1236837389-35687-2-git-send-email-brian.p.campbell@dartmouth.edu>
Hello Brian,
one more minor nitpick:
On Thu, Mar 12, 2009 at 01:56:29AM -0400, Brian Campbell wrote:
> -[ -n "$name" ] || name="$(git symbolic-ref HEAD | sed 's#^refs/\(heads\|top-bases\)/##')"
> +[ -n "$name" ] || name="$(current_branch)"

current_branch doesn't look like the correct name. I'd prefer current_tgpatch is better?! (For current_branch I would expect that only refs/heads is stripped.)

Best regards Uwe

-- 
Pengutronix e.K.                              | Uwe Kleine-König            |
Industrial Linux Solutions                    | http://www.pengutronix.de/  |
Previous: Uwe Kleine-König
Message 12 of 12 in “[TopGit] Portability: Use tr instead of sed for translating spaces to newlines”
  1. 1/2 [TopGit] Portability: Use tr instead of sed for translating spaces to newlinesBrian Campbell, Mar 12, 2009
  2. 2/2 [TopGit] Portability: Don't use alternation ("|") in sed regular expressionsBrian Campbell, Mar 12, 2009
  3. Junio C HamanoMar 12, 2009
  4. Uwe Kleine-KönigMar 12, 2009
  5. Brian CampbellMar 12, 2009
  6. Uwe Kleine-KönigMar 12, 2009
  7. martin f krafftMar 12, 2009
  8. Junio C HamanoMar 14, 2009
  9. Uwe Kleine-KönigMar 14, 2009
  10. Brian CampbellMar 12, 2009
  11. Uwe Kleine-KönigMar 12, 2009
  12. Uwe Kleine-KönigMar 12, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.