Re: [PATCH] Removed unnecessary use of global variables.

From: Nanako Shiraishi <nanako3@lavabit.com>
Date: Mar 11, 2009, 21:42 UTC
Message-ID: <20090312064237.6117@nanako3.lavabit.com>
In-Reply-To: <alpine.DEB.1.00.0903111126280.10279@pacific.mpi-cbg.de>

Quoting Johannes Schindelin <Johannes.Schindelin@gmx.de>:

Show 14 quoted lines

> Hi,
>
> On Wed, 11 Mar 2009, Erik Faye-Lund wrote:
>
>> git_config() now takes a third data-parameter that is passed back
>> to the callback-function. At the time this code was written, that
>> parameter did not exist, so a somewhat nasty (but by all means
>> correct) use of global variables was introduced. In commit
>> ef90d6d4208a5130185b04f06e5f90a5f9959fe3 Johannes Schindelin
>> <Johannes.Schindelin@gmx.de> introduced a parameter for similar
>> purposes.
>
> We tend to quote commits in this form: ef90d6d(Provide git_config with a 
> callback-data parameter)

Your review comments are a subset of the ones Junio sent about 8 hours before you did, and are almost identical except for the comment on the subject line yours didn't have. I'm curious about two things.

1. Are you and Junio one same person, and if so what made you change your mind during these 8 hours ;-)?

2. Junio said "ef90d6d (Provide git_config with a callback-data parameter, 2008-05-14)" and yours is slightly different. Both are equally readable but I think it would help to make sure everybody uses the same format within one project. Do we need a helper command that everybody can use?

-- 
Nanako Shiraishi
http://ivory.ap.teacup.com/nanako3/