Re: [PATCH JGIT] fix for 'negative position' error

From: Shawn O. Pearce <spearce@spearce.org>
Date: Mar 11, 2009, 15:24 UTC
Message-ID: <20090311152442.GS11989@spearce.org>
In-Reply-To: <49B7D683.1070805@diasoft.nl>

Ruth Alkema <ruth@diasoft.nl> wrote:

Show 10 quoted lines

> diff --git a/org.spearce.jgit/src/org/spearce/jgit/lib/WindowCache.java b/org.spearce.jgit/src/org/spearce/jgit/lib/WindowCache.java
> index 4b7e10d..5340da9 100644
> --- a/org.spearce.jgit/src/org/spearce/jgit/lib/WindowCache.java
> +++ b/org.spearce.jgit/src/org/spearce/jgit/lib/WindowCache.java
> @@ -253,7 +253,7 @@ private static synchronized final void getImpl(final WindowCursor curs,
>  		releaseMemory();
>  		runClearedWindowQueue();
>  
> -		wp.allocWindow(curs, id, id << windowSizeShift, wsz);
> +		wp.allocWindow(curs, id, ((long) id) << windowSizeShift, wsz);

Ouch.

Thanks for the fix!

-- 
Shawn.