Re: [PoC PATCH JGIT 0/2] Proof of concept code for Git Freenet transport

From: Shawn O. Pearce <spearce@spearce.org>
Date: Mar 9, 2009, 14:59 UTC
Message-ID: <20090309145955.GB11989@spearce.org>
In-Reply-To: <1236569765-8882-1-git-send-email-j16sdiz+freenet@gmail.com>

"Daniel Cheng (aka SDiZ)" <j16sdiz+freenet@gmail.com> wrote:

> 
> Here is some proof-of-concept code for Git-over-Freenet.
> I am sending this to see the feedback from communities.

Interesting!

I'm quite open to bringing this into JGit itself, so long as it doesn't cause us to import 42 other libraries that we don't need.

:-)

Show 5 quoted lines

> FIXME:
>  - How to store the private key of repository?
>    Currently, we use URI of form fcp://SSK@<public key>^<private key>/some-id
>    This is quite ugly. Could we use a per remote Config ? How can I get remote
>    name from transport?

Use something like amazon-s3 does, where there is a file path under ~/ specified by the host part of the URI, and store the data there?

I did that rather than storing into ~/.gitconfig or GIT_DIR/config as the private key really should remain private. Chmod'ing your config file to be private is a pain, and "git config" last I checked wouldn't preserve the permissions when it modified the file for you.

That said, the Transport API in JGit doesn't get access to the
RemoteConfig it was created with, because it isn't always made
from a remote (e.g. you can pass the URIish on the command line).
We could however optionally expose it, but in general I prefer
to make everything that can be obtained via the RemoteConfig be
settable without one, so it can also come through from the CLI
or some higher-level GUI.

>  - Make pushing async, could we?

I'm not sure I understand that. Do you want to background the push task? Isn't that what your shell is for? Or do you want to perform the writes in an async fashion in parallel, to reduce the latency?

-- 
Shawn.