Re: [EGIT PATCH] Show diff when double-clicking on file in commit dialog

From: Robin Rosenberg <robin.rosenberg.lists@dewire.com>
Date: Mar 8, 2009, 21:59 UTC
Message-ID: <200903082259.35886.robin.rosenberg.lists@dewire.com>
In-Reply-To: <49B4260D.6070501@nibor.org>

söndag 08 mars 2009 21:09:49 skrev Robin Stocker <robin@nibor.org>:

Show 13 quoted lines

> It only compares the index version to the working tree version for now.
> So if the file was already added to the index, the diff is empty. What
> it should show is the diff that will be in the commit.
> 
> Signed-off-by: Robin Stocker <robin@nibor.org>
> ---
> 
> Hi,
> 
> An essential feature I miss in EGit at the moment (apart from the
> synchronize view [1]) is seeing what changes one is about to commit. In
> the Subclipse SVN plugin one can double-click a file in the commit
> dialog and the diff is shown.

Hi, Robin. I miss that too!

> This patch is a first step for adding this to EGit. It only compares the
> index version to the working tree version as I couldn't figure out an
> easy way to get the HEAD version.

You can look at how GitDocument does it.

> 
> It's more a proof of concept than a final patch. What do you think?

I've started on an version with the diff integrated into the same dialog, for some reasons it's not done yet, but we might takes this meanwhile unless I complete the dialog real quick, as this is really useful, provided we compare with HEAD.

-- robin