git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Add tests for git log --pretty, --format and --oneline.

From
Jeff King <peff@peff.net>
Date
Feb 25, 2009, 10:20 UTC
Message-ID
<20090225102024.GA16894@coredump.intra.peff.net>
In-Reply-To
<7vljru4y9j.fsf@gitster.siamese.dyndns.org>
On Wed, Feb 25, 2009 at 02:16:40AM -0800, Junio C Hamano wrote:
Show 12 quoted lines
> >> Because 4202 seems to be about testing the log functionality and they rely
> >> on correctly working format output to verify other aspects of the
> >> operation of "git log", I initially was not sure if this is the right
> >> place to add these new tests.  After looking around I didn't find any
> >> existing test that checks the various --pretty output formats that the new
> >> tests can be added, so this probably is as good a place as any.
> >
> > t6006?
> 
> Good eyes.  But sorry I've already queued the four patches to 'next' and
> pushed the result out.  It probably is not worth moving the tests between
> two files as a follow-up patch.
Good memory; I wrote t6006. ;)

I don't think it is a big deal. I actually thought of it when I read the original patch but decided not to say anything. t6006 is really about exercising the formats themselves, so you could argue that the new tests go just as well in either spot.

-Peff
Previous: Junio C HamanoNext: Teemu Likonen
Message 10 of 17 in “--format, --pretty and --oneline”
  1. 0/3 --format, --pretty and --onelineNanako Shiraishi, Feb 24, 2009
  2. 1/3 Add --format that is a synonym to --prettyNanako Shiraishi, Feb 24, 2009
  3. 2/3 Give short-hands to --pretty=tformat:%formatstringNanako Shiraishi, Feb 24, 2009
  4. 3/3 Add --oneline that is a synonym to "--pretty=oneline --abbrev-commit"Nanako Shiraishi, Feb 24, 2009
  5. Junio C HamanoFeb 24, 2009
  6. Add tests for git log --pretty, --format and --oneline.Felipe Contreras, Feb 24, 2009
  7. Junio C HamanoFeb 25, 2009
  8. Jeff KingFeb 25, 2009
  9. Junio C HamanoFeb 25, 2009
  10. Jeff KingFeb 25, 2009
  11. bash completion: add --format= and --oneline options for "git log"Teemu Likonen, Feb 24, 2009
  12. bash completion: add --format= and --oneline options for "git log"Teemu Likonen, Feb 24, 2009
  13. Shawn O. PearceFeb 24, 2009
  14. Teemu LikonenFeb 24, 2009
  15. Shawn O. PearceFeb 24, 2009
  16. Teemu LikonenFeb 24, 2009
  17. Teemu LikonenFeb 27, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.