Re: [EGIT] [PATCH 1/2] Make sure to set core.bare to false when cloning

From: Shawn O. Pearce <spearce@spearce.org>
Date: Feb 23, 2009, 16:07 UTC
Message-ID: <20090223160719.GJ22848@spearce.org>
In-Reply-To: <80065b1339c7b235b19fa1f5a40a58dca335ae91.1235228532.git.ferry.huberts@pelagic.nl>

ferry.huberts@pelagic.nl wrote:

Show 6 quoted lines

> From: Ferry Huberts <ferry.huberts@pelagic.nl>
> 
> This is to make sure that the git plugin sets up a clone
> in the same fashion as the CLI git clone command.
> 
> Signed-off-by: Ferry Huberts <ferry.huberts@pelagic.nl>

Thanks. "jgit clone" also needed this added. I did that in a small followup patch.

Really though we need to fix the abstraction of Repository so there's a notion of a bare repository, and a repository+worktree. And that abstraction should then set the core.bare property accordingly when creating a new repository (or new repository+worktree). Unfortunately that hasn't happened yet...

> +		/* we're setting up for a clone with a checkout */
> +		local.getConfig().setBoolean("core", null, "bare", false);
> +

-- 
Shawn.