Re: [PATCH] git-tag: don't use gpg's stdin, stdout when signing tags
- From
Gerrit Pape <pape@smarden.org>
- Date
- Feb 23, 2009, 15:23 UTC
- Message-ID
- <20090223152303.9953.qmail@770db0999d0428.315fe32.mid.smarden.org>
- In-Reply-To
- <20090220134634.GJ4505@inocybe.teonanacatl.org>
On Fri, Feb 20, 2009 at 08:46:34AM -0500, Todd Zullinger wrote:
Show 14 quoted lines
> Gerrit Pape wrote: > > When using gpg with some console based gpg-agent, acquiring the > > passphrase through the agent fails if stdin and stdout of gpg are > > redirected. With this commit, git-tag uses temporary files instead > > of standard input/output when signing a tag to support such > > gpg-agent usage. > > > > The problem was reported by Loïc Minier through > > http://bugs.debian.org/507642 > > I sign tags using gpg-agent with the curse pinentry often and it works > here. Perhaps Loïc has not set GPG_TTY as the gpg-agent documentation > suggests? If I unset GPG_TTY, I get the sort of failure indicated in > the bug report. With it set tag signing works as expected.
Thanks a lot Todd and Johannes for teaching me. From my POV this patch can be dropped.
Regards, Gerrit.