Re: [PATCH] git-svn: Allow using arguments to the editor.

From: Thomas Rast <trast@student.ethz.ch>
Date: Feb 18, 2009, 14:15 UTC
Message-ID: <200902181515.59625.trast@student.ethz.ch>
In-Reply-To: <1234964869-11159-1-git-send-email-rhonda@deb.at>

Gerfried Fuchs wrote:

Show 6 quoted lines

> When setting the EDITOR or VISUAL environment variable, one might want
> to hand over arguments (like e.g. for not backgrounding a GUI editor but
> waiting for it to finish. This patch enables that posibility, before it
> did look for a program with the content of the variable, including the
> space as filename part. The change is in sync with regular behavior with
> various other tools, git itself included.

[...]

> +		my (@editor) = split /\s+/, $editor;

This doesn't handle quoted spaces and such. launch_editor() seems to pass the $EDITOR through 'sh -c' if there are any special characters inside, wouldn't that be appropriate for git-svn too?

-- 
Thomas Rast
trast@{inf,student}.ethz.ch