git-svn error: Unable to parse date

From: Ward Wouts <ward@wouts.nl>
Date: Feb 17, 2009, 09:48 UTC
Message-ID: <20090217094850.GQ7504@wouts.nl>

Hello,

I got the following error message while trying to fetch a subversion repository:

$ git svn init file:///home/mg/svn/mg git-svn-test Initialized empty Git repository in /home/ward/worktrees/git-svn-test/.git/ $ cd git-svn-test $ git svn fetch

r59 = c20f5b6c61bb8b2babc1b3644b6372e023d9d428 (git-svn)
W: +empty_dir: CFE
r60 = 1b8ad7c39dd60897319545c9f3f08b3b2b82b863 (git-svn)
        A       CFE/Makefile
Unable to parse date: 2004-03-09T09:44:33.Z
 at /usr/bin/git-svn line 3995

The message goes away with this one character patch:

$ diff -bru git-svn* --- git-svn 2009-02-17 10:23:24.000000000 +0100 +++ git-svn.orig 2009-02-17 10:20:30.000000000 +0100

@@ -2387,7 +2387,7 @@
 sub parse_svn_date {
        my $date = shift || return '+0000 1970-01-01 00:00:00';
        my ($Y,$m,$d,$H,$M,$S) = ($date =~ /^(\d{4})\-(\d\d)\-(\d\d)T
-                                           (\d\d)\:(\d\d)\:(\d\d).\d*Z$/x) or
+                                           (\d\d)\:(\d\d)\:(\d\d).\d+Z$/x) or
                                         croak "Unable to parse date: $date\n";
        "+0000 $Y-$m-$d $H:$M:$S";
 }



As the matching digits get ignored I don't see how this patch could introduce a
problem. Then again, I'm just starting with git and don't know anything about
the internals of either git or subversion.

Ward