Re: [PATCH] Re: Minor grammar fix in the 'Not a git repository' message

From: Lars Noschinski <lars@public.noschinski.de>
Date: Feb 17, 2009, 08:50 UTC
Message-ID: <20090217085028.GB7338@lars.home.noschinski.de>
In-Reply-To: <7vk57pevig.fsf@gitster.siamese.dyndns.org>

* Junio C Hamano <gitster@pobox.com> [09-02-17 01:51]:

Show 12 quoted lines

>Nicolas Sebrecht <nicolas.s-dev@laposte.net> writes:
>
>> The message
>> 	"Not inside a git repository" 
>> of Wincent looks like the clearest and the fairest one.
>
>I tend to agree.  I was only trying to see if we can salvage a more
>precise diagnosis f66bc5f (Always show which directory is not a git
>repository, 2008-12-22) tried to give users, but to do it throughly the
>sentence will become even more awkward.
>
>    "Not inside a bare git repository nor a work tree that has .git/ somewhere in it."

I think f66bc5f used the wrong path for the error message. If the comment above this part of the code is accurate, cwd is which should be belonging to a git repository, so I would suggest

     die("Not inside a git repository: %s", cwd)

  - Lars.